Merged
Conversation
This was returning early meaning only the first batch was being submitted. This caused truncation in test collection for large test suites.
mfiliba
approved these changes
May 2, 2025
Another small thing we noticed - even with the yield logic, it would have short circuited on the first exception. Now, it continues looping over the whole bach even if one of the requests hits an exception.
|
Thanks for submitting the PR, @jmsanders! We'll review internally and get back to you if there is any feedback. Cheers! |
nprizal
requested changes
May 5, 2025
Contributor
nprizal
left a comment
nprizal
left a comment
There was a problem hiding this comment.
@jmsanders Thanks for opening the PR. The changes look good to me. Good idea on using the generator. Can you add a test to ensure that when one upload batch fails, it doesn't affect the other batches? Also, there is pylint error.
Contributor
Author
|
Sounds good - added. |
nprizal
approved these changes
May 5, 2025
jimsynz
approved these changes
May 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was returning early meaning only the first batch was being submitted. This caused truncation in test collection for large test suites.